Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix restart notification showing wrong action order #12387

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Conversation

cezaraugusto
Copy link
Contributor

close #9750
per #10180 (comment)
Auditors: @srirambv

Test plan:

  1. try disabling pdfjs in extensions tab
  2. ensure buttons order is "no/yes" and "no" does nothing and "yes" restarts

@cezaraugusto cezaraugusto added this to the 0.20.x (Beta Channel) milestone Dec 22, 2017
@cezaraugusto cezaraugusto self-assigned this Dec 22, 2017
@bsclifton bsclifton self-requested a review December 24, 2017 06:20
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit f5d0f12 into master Dec 24, 2017
@bsclifton bsclifton deleted the 9750-2 branch December 24, 2017 06:21
bsclifton added a commit that referenced this pull request Dec 24, 2017
fix restart notification showing wrong action order
bsclifton added a commit that referenced this pull request Dec 24, 2017
fix restart notification showing wrong action order
@bsclifton
Copy link
Member

master f5d0f12
0.21.x 5fb8933
0.20.x bfc87c3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Yes/No buttons to Allow/Deny for easier understanding
3 participants