This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Randomise promotions intervals #12657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
hotfix/#12355-random
branch
from
ea61c0d to
39126fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #12657 +/- ##
==========================================
- Coverage 56.2% 56.14% -0.07%
==========================================
Files 278 278
Lines 27118 27140 +22
Branches 4393 4393
==========================================
- Hits 15241 15237 -4
- Misses 11877 11903 +26
|
evq
reviewed
Jan 16, 2018
app/browser/api/ledger.js
Outdated
|
|
||
| promotionTimeoutId = setTimeout(() => { | ||
| checkPromotions() | ||
| }, random.randomInt({min: 20 * ledgerUtil.milliseconds.second, max: 24 * ledgerUtil.milliseconds.second})) |
There was a problem hiding this comment.
should these be ledgerUtil.milliseconds.hour?
There was a problem hiding this comment.
you are correct, I was using seconds to test code out and forgot to change it back, nice catch
Resolves brave#12355 Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#12355-random
branch
from
39126fc to
a95e859
Compare
evq
approved these changes
Jan 16, 2018
alexwykoff
modified the milestones:
0.20.x Hotfix 3 (Ledger improvments),
0.21.x (Beta Channel)
bsclifton
added a commit
that referenced
this pull request
Feb 8, 2018
Randomise promotions intervals
bsclifton
added a commit
that referenced
this pull request
Feb 8, 2018
Randomise promotions intervals
NejcZdovc
pushed a commit
that referenced
this pull request
Feb 24, 2018
Randomise promotions intervals
|
0.21 twitch cd11167 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12355
Auditors:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests