This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13326 +/- ##
==========================================
+ Coverage 56.5% 56.5% +<.01%
==========================================
Files 284 284
Lines 28681 28710 +29
Branches 4737 4748 +11
==========================================
+ Hits 16206 16223 +17
- Misses 12475 12487 +12
|
NejcZdovc
force-pushed
the
hotfix/#13257-logging
branch
3 times, most recently
from
February 28, 2018 14:28
35a4428
to
da716d0
Compare
mrose17
previously approved these changes
Mar 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! this is a great improvement.
Resolves brave#13257 Auditors: Test Plan:
bsclifton
force-pushed
the
hotfix/#13257-logging
branch
from
March 15, 2018 16:11
da716d0
to
2e207ce
Compare
bsclifton
approved these changes
Mar 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried skipping back and forth, mixing in with live stream.
All scenarios I tried worked great! 😄 Awesome job
bsclifton
added a commit
that referenced
this pull request
Mar 15, 2018
Improves twitch logging time
bsclifton
added a commit
that referenced
this pull request
Mar 15, 2018
Improves twitch logging time
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13257
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Goal of this PR is to improve time logging when you play VOD (recorded videos).
LEDGER_LOGGING=true npm run start
(this will help you check out events)Reviewer Checklist:
Tests