Fixing recovery progress indicator showing before a recovery file has been loaded.

[ryanml]

Fixes: #14014

The in progress overlay now waits for:
A recovery file to have been loaded
A recovery to then start off of the loaded file

This PR also includes some refactoring by way of adding setRecoveryInProgress to aboutPreferencesState. Tests have been updated to reflect both the refactoring and the fix.

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

1. Enable payments
2. Go to advance settings, recover your wallet
3. Click import recovery keys, confirm recovery progress message does not show.
4. Exit Brave. Corrupt your wallet by removing seeds 20 and 21 from ledger-state.json
5. Restart brave, recover your wallet by clicking import recovery key but then hit cancel as opposed to choosing a file.
6. Confirm recovery progress message does not show
7. Load in an actual recovery file.
8. Confirm recovery progress messages shows for the duration of the recovery
9. [Regression testing via pasting in a recovery key]

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[codecov-io]

Codecov Report

Merging #14017 into master will decrease coverage by 0.1%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master   #14017      +/-   ##
==========================================
- Coverage   56.51%    56.4%   -0.11%     
==========================================
  Files         284      284              
  Lines       29357    29392      +35     
  Branches     4880     4880              
==========================================
- Hits        16590    16580      -10     
- Misses      12767    12812      +45

Flag	Coverage Δ
#unittest	56.4% <92.85%> (-0.11%)	⬇️

Impacted Files	Coverage Δ
app/browser/api/ledger.js	63.1% <0%> (-0.56%)	⬇️
app/common/state/aboutPreferencesState.js	100% <100%> (ø)	⬆️
app/browser/reducers/ledgerReducer.js	44.51% <100%> (-3.56%)	⬇️
.../renderer/components/navigation/publisherToggle.js	81.25% <0%> (-0.17%)	⬇️
js/actions/appActions.js	19.16% <0%> (ø)	⬆️
app/renderer/components/preferences/paymentsTab.js	65.56% <0%> (ø)	⬆️

[ryanml]

tests added

[jasonrsadler]

++ Works great 🥇

[NejcZdovc]

master af63e87
0.23 e465f39
0.22-release3 a7c4c48