Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

WIP show UI indicator on Tor tabs #14206

Closed
wants to merge 19 commits into from
Closed

WIP show UI indicator on Tor tabs #14206

wants to merge 19 commits into from

Conversation

diracdeltas
Copy link
Member

fix #14175

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

riastradh-brave and others added 19 commits May 17, 2018 14:13
@riastradh-brave @diracdeltas
Tor MVP
576d83b 
Support isolated_storage and tor_proxy
requires brave/muon#473

Use Session::IsOffTheRecord to detect private tab
requires
brave/muon@edad1b2

Set Tor new identify
fix #12997
requires
brave/muon@7e052dd

Session::IsOffTheRecord for app/filtering

Refresh page after getting new identity
requires
brave/muon@c3d6769

implement switch Tor Private Tabs in about:newtab
set isTor depending on tor private tab setting and tor availability
close/re-open private tab when tor switch is toggled
Recreate tor private tab at the same index it was previously at
always enable new identity button for now

Disable search suggestions in private mode for Tor
Fix #13064

set ddg as default search engine in tor private tabs
fix #13212

Disable webtorrent in tor private mode
fix #13063

load favicons in Tor tabs as data: URLs
fix #13065

Omit unlocked icon for HTTP onion sites
Fix #12990
also fix unittests
Test Plan:
1. go to http://3expgpdnrrzezf7r.onion/ in a private tab
2. no icon should be in the urlbar
3. go to https://3g2upl4pq6kufc4m.onion/
4. you should see a lock icon

disable webrtc in tor mode
fix #13397
add note to shields panel about breakage in tor mode

Tor binary path will be passed from browser-laptop (#13455)

Disable widevine notification on Tor tabs
needed for #13396
Test Plan:
1. go to https://shaka-player-demo.appspot.com in a tor private tab
2. you should not see a widevine notification

disable plugins in Tor private tabs

Workaround browser-context-created not being emitted for tor tabs

Disable flash click to play on tor tabs
TODO: figure out a way to disable widevine on a per-tab basis
Test Plan:
1. ensure flash is installed and enabled in preferences
2. go to https://get.adobe.com/flashplayer/about/
3. make sure there is no popup asking you to run flash
4. right click on the flash click-to-play element (looks like a puzzle
   piece) on the page. no context menu should appear.

deny geolocation in tor mode
fix #13447

implement new tor tabs mockup
fix #12922

implement new Tor New Identity UX
fix #13658
Test Plan:
1. open new private tab
2. go to check.torproject.org and open shields
3. click 'new circuit' button in shields
4. it should reload the page and show a new IP
5. open shields again, click the info circle next to 'new circuit'
5. it should open a FAQ page

Bundling tor with Brave

Set the tor socks port and data directory. (#13641)
Pass the port and data directory down for tor to use depending on channel

bind tor new circuit to hard refresh in tor tabs
fix #13925

upgrade to muon 6.1.0 for tor API support
@diracdeltas
0.23.1
b74e473
@diracdeltas
fixes to tor build scripts
2f9e2ee 
0.23.2
@diracdeltas
initialize Tor partition at startup
bb28409 
to reduce delay when opening the tor private tab, in preparation for
moving tor initialization to startup.

Auditors: @darkdh
@diracdeltas
Link to Tor FAQ in newtab, update muon, disable safebrowsing
a74d41b 
0.23.4
@diracdeltas
add basic tor webdriver tests
33105b3 
fix #13821
@bsclifton @diracdeltas
Update Muon to 6.1.4 and use stable tor binaries
591e6fb
@diracdeltas
0.23.5
288e260
@diracdeltas
update package-lock to fix nsp issue
45d4b0a
@diracdeltas
0.23.6
dfe0b1b
@diracdeltas
fix tor wiki link
7cd426c 
fix #14156
@diracdeltas
Open link in new private tab should use tor if enabled
63f1bea 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
@diracdeltas
Styling fixes based on david's feedback
85fc84d
@diracdeltas
update to muon 6.1.5
558556b 
Auditors: @riastradh-brave
@jumde @diracdeltas
updated hash
2321226
@diracdeltas
Update to new extra-private icon
a93cfd4 
fix #14121
0.23.7
f0e0dea
@diracdeltas
Add slash to end of torproject URL
5a73788 
fix #14121
@diracdeltas
add tor tabs icon
c9cae58 
fix #14175
@diracdeltas diracdeltas self-assigned this May 22, 2018
@diracdeltas diracdeltas requested a review from rossmoody May 22, 2018 06:46
@rossmoody
Copy link
Contributor

rossmoody commented May 22, 2018 •
edited
Loading

Replacing the toricon.svg code with this should do the trick here: <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 16"><defs><style>.cls-2{fill:#fff}</style></defs><g id="Layer_2" data-name="Layer 2"><g id="_32px" data-name="32"><path fill="none" d="M0 0h32v16H0z"/><path class="cls-2" d="M0 4.62v-2h8.32v2H5.43v8.81H2.87V4.62zM12 12a5.4 5.4 0 0 1-1.57-4A5.33 5.33 0 0 1 12 4a5.22 5.22 0 0 1 3.84-1.57A5.17 5.17 0 0 1 19.67 4a5.36 5.36 0 0 1 1.55 4 5.43 5.43 0 0 1-1.56 4 5.16 5.16 0 0 1-3.82 1.57A5.2 5.2 0 0 1 12 12zm5.85-1.71A3.26 3.26 0 0 0 18.61 8a3.24 3.24 0 0 0-.76-2.26 2.56 2.56 0 0 0-2-.85 2.58 2.58 0 0 0-2 .85A3.28 3.28 0 0 0 13 8a3.31 3.31 0 0 0 .76 2.27 2.6 2.6 0 0 0 2 .84 2.58 2.58 0 0 0 2.09-.85zM26.33 9.23v4.2h-2.57V2.62h4.16a4 4 0 0 1 2.85 1 3.09 3.09 0 0 1 1 2.34 3.46 3.46 0 0 1-.56 1.83A3 3 0 0 1 29.42 9L32 13.43h-3l-2.37-4.2zm0-4.61v2.6h1.59a1.24 1.24 0 0 0 .92-.35 1.29 1.29 0 0 0 .34-.93 1.32 1.32 0 0 0-.35-1 1.17 1.17 0 0 0-.91-.37z"/></g></g></svg>

@diracdeltas
Copy link
Member Author

@rossmoody thanks i'll try that now!

@diracdeltas
Copy link
Member Author

included with 6a5e8a9 !

@bsclifton bsclifton deleted the tor/tabs-ui branch August 18, 2018 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rossmoody rossmoody Awaiting requested review from rossmoody

Assignees

@diracdeltas diracdeltas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diracdeltas @rossmoody @riastradh-brave @bsclifton @jumde