Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move tabs toolbar mouseleave handler to parent element #14478

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

petemill
Copy link
Member

… which does not use 'contents' value for display style property

Since a display: contents container will essentially be the width of its children, and the child was being removed on tab close, the width of the parent element was narrowing so that the mouse was no longer on top, but the mouseleave event did not fire. Moving this handler to a parent element fixes it. It encompasses the pinned tabs but this should not be an issue as the intention of the feature is to relate to the tabs bar as a whole.

Fix #14477

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

On issue

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

… use 'contents' value for display style property

Since a `display: contents` container will essentially be the width of its children, and the child was being removed on tab close, the width of the parent element was narrowing so that the mouse was no longer on top, but the mouseleave event did not fire. Moving this handler to a parent element fixes it. It encompasses the pinned tabs but this should not be an issue as the intention of the feature is to relate to the tabs bar as a whole.

Fix #14477
@petemill petemill added this to the 0.23.x (Beta Channel) milestone Jun 20, 2018
@petemill petemill self-assigned this Jun 20, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 😄 ++

@bsclifton bsclifton merged commit c4b18cd into master Jun 21, 2018
@bsclifton bsclifton deleted the fix/14477-tab-close-move-mouse-width branch June 21, 2018 05:17
bsclifton added a commit that referenced this pull request Jun 21, 2018
…idth

Move tabs toolbar mouseleave handler to parent element
bsclifton added a commit that referenced this pull request Jun 21, 2018
…idth

Move tabs toolbar mouseleave handler to parent element
@bsclifton
Copy link
Member

master c4b18cd
0.24.x de04be9
0.23.x cc62793

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing the last tab on full tabstrip and moving mouse away does not restore tab width
2 participants