Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make the entire height of the url bar a hit target for focus #14512

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Jun 22, 2018

Fix #14473

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

On #14473

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added this to the 0.23.x (Beta Channel) milestone Jun 22, 2018
@petemill petemill self-assigned this Jun 22, 2018
@petemill petemill requested a review from bsclifton June 22, 2018 00:10
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 20dbf1b into master Jun 22, 2018
@bsclifton bsclifton deleted the fix/14473-url-bar-input-height branch June 22, 2018 04:02
bsclifton added a commit that referenced this pull request Jun 22, 2018
Make the entire height of the url bar a hit target for focus
bsclifton added a commit that referenced this pull request Jun 22, 2018
Make the entire height of the url bar a hit target for focus
@bsclifton
Copy link
Member

master 20dbf1b
0.24.x 4238d9f
0.23.x fb6b97b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants