This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Handle reload by setUrl in window store #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave#5177 Auditors: @bbondy Test Plan: 1. Type brave.123 in navigation bar 2. After DNS error page is presented, click refresh button next to navigation bar 3. The error page refresh normally 1. Type brave.123 in navigation bar 2. After DNS error page is presented, click "Retry the URL" in error page 3. The error page refresh normally 1. Navigate to https://expired.badssl.com/ 2. After cert error page is presented, click refresh button next to navigation bar 3. The error page refresh normally 1. Navigate to https://expired.badssl.com/ 2. After cert error page is presented, click "Retry the URL" in error page 3. The error page refresh normally 1. Make network unavailable 2. Type anything in navigation bar 3. After connection error page is presented, click refresh button next to navigation bar 4. The error page refresh normally 1. Make network unavailable 2. Type anything in navigation bar 3. After connection error page is presented, click "Retry the URL" in error page 4. The error page refresh normally 1. Make network unavailable 2. Type anything in navigation bar 3. After connection error page is presented, make network available 4. Click refresh button next to navigation bar 5. The original page should load 1. Make network unavailable 2. Type anything in navigation bar 3. After connection error page is presented, make network available 4. Click "Retry the URL" in error page 5. The original page should load
|
++ |
This was referenced Oct 27, 2016
This does not happen on 0.12.7 RC1 for Windows 10. If I click "Retry the URL", only the blank page is shown. |
This was referenced Oct 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #5177
Auditors: @bbondy
Test Plan: