Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Apply no-drag to all direct descendants except for .endButtons #6780

Closed
wants to merge 1 commit into from
Closed

Apply no-drag to all direct descendants except for .endButtons #6780

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 20, 2017

Closes #5792

Auditors:

Test Plan:

  1. Make sure the non-draggable area specified in Added noscript into the URL bar - Move noscript into the URL bar #5792 is draggable
  2. Make sure every button on the navigation bar is clickable
  3. Open https://jsfiddle.net/
  4. Block scripts from the top right lion icon
  5. Make sure the noScript button on the navigation bar is clickable
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@luixxiul luixxiul changed the title Apply no-drag all direct descendants except for .endButtons Apply no-drag to all direct descendants except for .endButtons Jan 20, 2017
Closes #5792

Auditors:

Test Plan:
1. Make sure the non-draggable area specified in #5792 is draggable
@luixxiul luixxiul added this to the 0.13.1 milestone Jan 20, 2017
@luixxiul luixxiul removed this from the 0.13.1 milestone Jan 20, 2017
@luixxiul luixxiul closed this Jan 20, 2017
@luixxiul luixxiul deleted the fix-draggable-endButtons branch January 20, 2017 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant