This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor HelpfulHints component #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luixxiul
reviewed
Feb 14, 2017
| helpfulHints: { | ||
| display: 'block', | ||
| width: '100%', | ||
| color: '#eee', |
There was a problem hiding this comment.
I know this comes from the original code but I thought making this white and setting #eee to elements which require it should be better.
But #eee is not used anywhere so this can be just replaced with white.
luixxiul
reviewed
Feb 14, 2017
| <span className={css(styles.hintsTitle)} data-l10n-id='hintsTitle' /> | ||
| <span className='fa fa-refresh' onClick={this.props.refreshHint} | ||
| style={{ | ||
| color: 'white', |
There was a problem hiding this comment.
This can be removed based on that.
There was a problem hiding this comment.
I had to keep it so FA icon can be white.
|
@cezaraugusto I created a commit as a suggestion: https://github.com/luixxiul/browser-laptop/commit/6be5e72a1d1a81944184665c93b0d0e39482eb6f. Please cherry-pick it if you like it 😄 |
|
super clean now, thanks |
|
++ |
bsclifton
approved these changes
Feb 15, 2017
bsclifton
added
QA/test-plan-specified
release-notes/include
release-notes/exclude
and removed
PR/ready-for-merge
release-notes/include
labels
bbondy
reviewed
Feb 15, 2017
| @@ -1174,22 +1175,6 @@ class PreferenceNavigationButton extends ImmutableComponent { | |||
| } | |||
| } | |||
|
|
|||
| class HelpfulHints extends ImmutableComponent { | |||
There was a problem hiding this comment.
++ for making preferences.js less huge too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Description
git rebase -ito squash commits (if needed).Auditors: @luixxiul
Fix #7232