Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Restore ability to delete bookmark custom title #7714

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 14, 2017

Fix #7691

Test Plan:

  1. automated bookmark tests should pass
  2. try editing a bookmark and fully deleting the title. the title field should be empty.
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@diracdeltas diracdeltas added this to the 0.14.0 milestone Mar 14, 2017
Fix #7691

Test Plan:
1. automated bookmark tests should pass
2. try editing a bookmark and fully deleting the title. the title field should be empty.
Copy link

@cndouglas cndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works correctly. Thanks for the quick fix!

@diracdeltas diracdeltas merged commit b82035e into master Mar 14, 2017
@bsclifton
Copy link
Member

++ 😄

@bsclifton bsclifton deleted the fix/7691 branch March 14, 2017 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants