Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make private tab color predominant #7722

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Make private tab color predominant #7722

merged 1 commit into from
Mar 15, 2017

Conversation

cezaraugusto
Copy link
Contributor

Auditors: @bsclifton

Fix #7720
Fix #7715

purple_is_the_new_private

/cc @bradleyrichter

Test Plan:

  • If a tab is private, it should be purple even if themeColor is defined

@cezaraugusto cezaraugusto added accessibility design A design change, especially one which needs input from the design team. feature/tabsbar privacy labels Mar 15, 2017
@cezaraugusto cezaraugusto added this to the 0.14.0 milestone Mar 15, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 15, 2017
bsclifton
bsclifton approved these changes Mar 15, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great 😄 ++

bsclifton
bsclifton suggested changes Mar 15, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was playing around with session tabs for comparison and noticed a bug (similar in nature to this)

If you open a new session tab and switch to it, the close button is white when you do a mouse over:
screen shot 2017-03-14 at 10 46 44 pm

@jonathansampson
Copy link
Collaborator

jonathansampson commented Mar 15, 2017 •
edited
Loading

@bsclifton I'm not able to repro the New Session Tab issue you're seeing:

image

jonathansampson
jonathansampson reviewed Mar 15, 2017
View reviewed changes
Copy link
Collaborator

@jonathansampson jonathansampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues in my quick test, but @bsclifton did.

@cezaraugusto
Copy link
Contributor Author

@bsclifton can't repro. Can you give a more detailed STR?

bsclifton
bsclifton approved these changes Mar 15, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird- definitely can't repro now...

Before I tested (both today and yesterday), I did rebase against master. Yesterday may have had a conflict causing the white text; it works great now 😄

@bsclifton
Copy link
Member

@cezaraugusto if you can go ahead and rebase, I'll merge (assuming @jonathansampson didn't have any objections 😄 )

@cezaraugusto
Copy link
Contributor Author

thanks rebased

@bsclifton bsclifton merged commit 3b3ad3c into brave:master Mar 15, 2017
@cezaraugusto cezaraugusto mentioned this pull request Mar 15, 2017
Closed
@jonathansampson jonathansampson mentioned this pull request Mar 15, 2017
Closed
@luixxiul luixxiul removed the request for review from NejcZdovc March 16, 2017 09:06
@cezaraugusto cezaraugusto deleted the tabsbar/7720 branch July 25, 2017 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@jonathansampson jonathansampson jonathansampson approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
accessibility design A design change, especially one which needs input from the design team. feature/tabsbar privacy
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cezaraugusto @jonathansampson @bsclifton