Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change closeTab icon from circled to squared #7851

Merged
merged 2 commits into from
Mar 23, 2017
Merged

Change closeTab icon from circled to squared #7851

merged 2 commits into from
Mar 23, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 23, 2017

Auditors: @bsclifton

Fix #5431

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Last attempt to fix this had a report by @luixxiul and @srirambv that close icon had a clickable area outside icon itself (which were circled). I did a local fix which included replacing <span> with <map> + <area> (so the linkable area could be rounded as well), but needed an image instead of a fontAwesome icon. While asking for a new one @bradleyrichter suggested a new icon, which solved issue anyway:

screen shot 2017-03-22 at 11 57 12 pm

Test Plan:

  • Automated tests must still pass:
npm run test -- --grep="tabContent components"

QA Steps:

  • You should only close a tab if you intentionally hit the close button.

@cezaraugusto cezaraugusto self-assigned this Mar 23, 2017
@cezaraugusto cezaraugusto added this to the 0.14.0 milestone Mar 23, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close (and wow- this looks good!)

Here's a breakpoint I found where the tab's close button became very skinny and almost unclickable:
close-button

@cezaraugusto
Copy link
Contributor Author

thanks, fixed

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great! 😄 Nice work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable close button on tabs if tab size is too small
3 participants