This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Change closeTab icon from circled to squared #7851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bsclifton
Fix #5431
git rebase -i
to squash commits (if needed).Last attempt to fix this had a report by @luixxiul and @srirambv that close icon had a clickable area outside icon itself (which were circled). I did a local fix which included replacing
<span>
with<map>
+<area>
(so the linkable area could be rounded as well), but needed an image instead of a fontAwesome icon. While asking for a new one @bradleyrichter suggested a new icon, which solved issue anyway:Test Plan:
QA Steps: