Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix Pocket setting l10 #8110

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Fix Pocket setting l10 #8110

merged 1 commit into from
Apr 7, 2017

Conversation

cndouglas
Copy link

@cndouglas cndouglas commented Apr 7, 2017

Test Plan: (requires up-to-date translations)

  1. Change to a language (Preferences > General > Language) with a up-to-date translation for enableExtension (see en-US/preferences.properties for an example).
  2. Open Preferences > Advanced.
  3. Find the setting Enable Pocket under Extensions.
  4. Make sure the setting matches "Pocket" exactly and is not translated.

Description

Fixes #7450

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@cndouglas cndouglas added this to the 0.14.3 milestone Apr 7, 2017
@cndouglas cndouglas self-assigned this Apr 7, 2017
@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.3 Apr 7, 2017
@bsclifton bsclifton self-requested a review April 7, 2017 17:13
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks/works great! Super glad you found data-l10n-args... (I had forgotten about that). Well done 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants