This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Make torrent file names on the table selectable #8150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Apr 9, 2017
| } | ||
| } | ||
| } | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| userSelect: { |
There was a problem hiding this comment.
Please move this two definition into the common file and use it in all files
There was a problem hiding this comment.
Updated. Will squash later.
Closes #8148 Also: - Added testIds to the buttons for future work - Made missingFilesList, loadingFilesList, torrentStats, and legalNotice unselectable Auditors: Test Plan: 1. Open https://webtorrent.io/free-torrents 2. Click "Big Buck Bunny (magnet link)" 3. Make sure nothing is selectable 4. Click "Start download" 5. Make sure only the file names on the table are selectable
|
@NejcZdovc done |
|
Save file icon is also selectable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8148
Also:
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).