Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Covers instances of 'GoogleChrome' #8182

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Covers instances of 'GoogleChrome' #8182

merged 1 commit into from
Apr 10, 2017

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented Apr 10, 2017

Automated test plan

npm run unittest -- --grep="extensionsUtil bravifyText"

Description

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #8181

Also removes old stub version of bravifyText from js/about/extensions.js.

@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 10, 2017
@bsclifton
Copy link
Member

@jonathansampson can you update this (and the original issue) to have testing steps? Thanks 😄

@bsclifton bsclifton merged commit 6306259 into master Apr 10, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jonathansampson
Copy link
Collaborator Author

@bsclifton In this particular case, you would need to have an older session-store-1 file that had Pocket's name/description cached. Upon updating Brave, the cached name/description from session-store-1 would be loaded, and the incorrect value would be shown.

I don't think this will be something we need to watch moving forward.

We could, and probably should, write a few unit tests for bravifyText though.

@bsclifton
Copy link
Member

@jonathansampson ah ok... unit tests work 😄 Would you be able to make some? (I can help if needed, let me know). Then we can mark this as no QA needed, since it would be covered by automated tests

@jonathansampson
Copy link
Collaborator Author

@bsclifton I still have issues running tests on Windows, but I think Unit Tests will work easier than the Chrome Driver ones. I'll write up a couple tests, and see if they work as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants