This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Looking up site using tab details now considers provisionalLocation #8588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
May 1, 2017
js/state/siteUtil.js
Outdated
| @@ -444,14 +444,69 @@ module.exports.getDetailFromFrame = function (frame, tag) { | |||
| }) | |||
| } | |||
|
|
|||
| module.exports.getDetailFromTab = function (tab, tag) { | |||
| const getSitesLikeKey = (sites, siteKey, tag) => { | |||
| if (!sites || !siteKey) { | |||
There was a problem hiding this comment.
getSitesLikeKey seems not very instinctive to me. Maybe getSiteBySubKey? And we can extend this function to support more sub key if needed
There was a problem hiding this comment.
sorry my bad for typo. I think it should be getSitesBySubkey the plural 😛
| let location = tab.get('url') | ||
| const partitionNumber = tab.get('partitionNumber') !== undefined | ||
| ? tab.get('partitionNumber') | ||
| : undefined |
There was a problem hiding this comment.
I left as undefined so that it would skip the below code, which only sets if the value is truthy:
if (partitionNumber) {
siteDetail.partitionNumber = partitionNumber
|
@darkdh updated per feedback 👍 (reviewers: please don't merge without squashing!) |
Result returned now includes parentFolderId Fixes #8477 Auditors: @bbondy, @NejcZdovc cc: @darkdh Includes: Fixes per feedback per @darkdh
|
Verified folder test case on Windows 10 x64 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
folder case
redirect case
Description
This PR fixes two bugs with pinned tabs
Looking up site using tab details now considers provisionalLocation
Result returned now includes parentFolderId
Fixes #8477
Auditors: @bbondy, @NejcZdovc
cc: @darkdh
git rebase -ito squash commits (if needed).