Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add base64-js to devDependencies #8713

Merged
merged 1 commit into from
May 5, 2017
Merged

Add base64-js to devDependencies #8713

merged 1 commit into from
May 5, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 5, 2017

Fix #8712

Auditors:

Test Plan:

  1. rm -rf node_modules
  2. npm i
  3. npm run watch
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Fix #8712

Auditors:

Test Plan:
1. rm -rf node_modules
2. npm i
3. npm run watch
@luixxiul luixxiul added this to the 0.15.3 milestone May 5, 2017
@luixxiul luixxiul self-assigned this May 5, 2017
@bbondy
Copy link
Member

bbondy commented May 5, 2017

not sure why this is needed, but given the error above ++

@bbondy bbondy merged commit 01cd05c into brave:master May 5, 2017
@luixxiul luixxiul deleted the base64-js branch May 5, 2017 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants