Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

noscript exceptions from private tabs should not apply to regular tabs #8783

Merged
merged 1 commit into from
May 10, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 10, 2017

fix #8779

Test Plan:

  1. disable scripts on twitter.com
  2. open twitter.com in a private tab. scripts should be disabled.
  3. click the noscript icon to allow scripts in the private tab.
  4. load twitter again in a regular tab. scripts should still be disabled.
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #8779

Test Plan:
1. disable scripts on twitter.com
2. open twitter.com in a private tab. scripts should be disabled.
3. click the noscript icon to allow scripts in the private tab.
4. load twitter again in a regular tab. scripts should still be disabled.
@diracdeltas diracdeltas added this to the 0.15.400 milestone May 10, 2017
@diracdeltas diracdeltas self-assigned this May 10, 2017
@diracdeltas diracdeltas requested a review from ayumi May 10, 2017 00:25
Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test plan success

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noscript approvals from private tabs apply to regular tabs
3 participants