Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Handle show-warning-dialog event on app #8864

Merged
merged 1 commit into from
May 16, 2017
Merged

Handle show-warning-dialog event on app #8864

merged 1 commit into from
May 16, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented May 13, 2017

requires brave/muon#196

fix #8846

Auditors: @bridiver, @bbondy

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Open Firefox
  2. Open Brave and import from Firefox
  3. There will be a warning window

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run indivually or as a suite ref

requires brave/muon#196

fix #8846

Auditors: @bridiver, @bbondy

Test Plan:
1. Open Firefox
2. Open Brave and import from Firefox
3. There will be a warning window
@darkdh darkdh added this to the 0.15.300 milestone May 13, 2017
@darkdh darkdh self-assigned this May 13, 2017
@darkdh darkdh requested review from bridiver and bbondy May 13, 2017 04:01
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 😄

@bsclifton bsclifton merged commit 7e4156c into master May 16, 2017
@bsclifton bsclifton deleted the 8846 branch May 16, 2017 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importer warning doesn't work
2 participants