Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes lion badge when disabled #8893

Merged
merged 1 commit into from
May 17, 2017
Merged

Fixes lion badge when disabled #8893

merged 1 commit into from
May 17, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 16, 2017 •
edited by bsclifton
Loading

Test Plan

  • Visit any site
  • Disable shields
  • Lion head is grayed out

Description

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8889

Auditors: @bsclifton

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.15.300 milestone May 16, 2017
@NejcZdovc NejcZdovc self-assigned this May 16, 2017
@NejcZdovc
Fixes lion badge when disabled
b9e3b53 
Resolves brave#8889

Auditors: @bsclifton

Test Plan:
- Visit any site
- Disable shields
- Lion head is grayed out
@NejcZdovc NejcZdovc force-pushed the hotfix/#8889-lion branch from 379678a to b9e3b53 Compare May 17, 2017 07:35
@NejcZdovc NejcZdovc requested a review from bsclifton May 17, 2017 07:42
luixxiul
luixxiul approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan works. the automated test works too.

bsclifton
bsclifton approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄 Huge thanks for adding a test for this too! ❤️

@bsclifton bsclifton merged commit df7aea7 into brave:master May 17, 2017
@srirambv srirambv mentioned this pull request May 17, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@luixxiul luixxiul luixxiul approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/shields QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @luixxiul @bsclifton