This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
offer pinterest-save extension #9527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Jun 16, 2017
app/extensions.js
Outdated
| @@ -518,11 +522,17 @@ module.exports.init = () => { | |||
| } | |||
|
|
|||
| if (getSetting(settings.HONEY_ENABLED)) { | |||
| registerComponent(config.honeyExtensionId) | |||
| registerComponent(config.honeyExtensionId, 'MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC79mayLyuCYY/dyT7Ycr1sVBp9yHrY4mnogVEgu+sDT6+/A121Na+aTw6mFLD6LHgbgHt4fnQ2V/QwcfBSXRTSkGpgNsZAjnYs4/XzZQYKGltWT93EP9zXN1kGbtzfkPGzTakquCfOjbKtbAQKWh8ppzqLhWcRUn9g/PhU99F29QIDAQAB') | |||
There was a problem hiding this comment.
can we put this in config with the extension id?
There was a problem hiding this comment.
should be able to. let me see
#6366 works with base64 extension changes to muon see brave/muon@b346a92 Auditors: @bridiver @jonathansampson Test Plan: linting Auditors: Test Plan: move public keys to config file Auditors: Test Plan:
kevinlawler
force-pushed
the
extensions/pinterest-create
branch
from
59d32fc to
0ab7e02
Compare
bridiver
approved these changes
Jun 19, 2017
bsclifton
modified the milestones:
0.18.x (Developer Channel),
0.19.x (Nightly Channel)
|
We need to pull this into 0.18, because we use the same Muon version now and 0.18 is failing because of that: |
bsclifton
modified the milestones:
0.19.x (Nightly Channel),
0.18.x (Developer Channel)
|
Setting back to 0.19.x. I don't think we are able to use Muon 4.2.x in 0.18.x |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6366
compatible with base64 extension changes to muon
see brave/muon@b346a92
Auditors:
@bridiver @jonathansampson
Test Plan:
linting
Auditors:
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests