This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes close tabs to the left/right #9790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR blocked by #9773 |
NejcZdovc
force-pushed
the
hotfix/#9789-tabpage
branch
from
bcda03f to
ba0ca31
Compare
NejcZdovc
force-pushed
the
hotfix/#9789-tabpage
branch
from
ba0ca31 to
84aee6e
Compare
|
|
NejcZdovc
force-pushed
the
hotfix/#9789-tabpage
branch
2 times, most recently
from
5d0301d to
0f509d4
Compare
bbondy
suggested changes
Jul 14, 2017
bbondy
reviewed
Jul 14, 2017
| { | ||
| const currentIndex = frameStateUtil.getIndexByTabId(state, action.tabId) | ||
| if (currentIndex === -1) { | ||
| return |
There was a problem hiding this comment.
I know it was like this before as well but this should be returning state here.
|
Ideally this whole thing would happen in the browser side instead but I know this is just a small fix to an existing bug so it's ok in general. But longer term we should refactor it. Test problem and returning state are blockers though. |
NejcZdovc
force-pushed
the
hotfix/#9789-tabpage
branch
from
0f509d4 to
96d3a14
Compare
|
@bbondy Test fixed as well. Should be good to go now |
NejcZdovc
force-pushed
the
hotfix/#9789-tabpage
branch
from
96d3a14 to
a47b252
Compare
when you have multiple tab pages Resolves brave#9789 Auditors: @bsclifton Test Plan:
NejcZdovc
force-pushed
the
hotfix/#9789-tabpage
branch
from
a47b252 to
4342b8c
Compare
cezaraugusto
approved these changes
Jul 14, 2017
bbondy
added a commit
that referenced
this pull request
Jul 14, 2017
Fixes close tabs to the left/right
|
Doesn't apply without redux to 0.18.x so we're moving this to 0.19.x |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you have multiple tab pages
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #9789
Auditors: @bsclifton
Test Plan:
Reviewer Checklist:
Tests