more fixes for node-gyp install with version > 3

auditors @bbondy
brave · Jun 7, 2017 · 1e79785 · 1e79785
1 parent b1bccb6
commit 1e79785
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/script/upload-node-checksums.py b/script/upload-node-checksums.py
@@ -46,6 +46,8 @@ def get_files_list(version):
     'x64/node.lib',
     'win-x86/iojs.lib',
     'win-x64/iojs.lib',
+    'win-x86/node.lib',
+    'win-x64/node.lib',
   ]
 
 

diff --git a/script/upload-node-headers.py b/script/upload-node-headers.py
@@ -116,21 +116,27 @@ def upload_node(bucket, access_key, secret_key, version):
   if PLATFORM == 'win32':
     if get_target_arch() != 'x64':
       node_lib = os.path.join(dist_dir(), 'node.lib')
+      node2_lib = os.path.join(dist_dir(), 'win-x86', 'node.lib')
       iojs_lib = os.path.join(dist_dir(), 'win-x86', 'iojs.lib')
     else:
       node_lib = os.path.join(dist_dir(), 'x64', 'node.lib')
+      node2_lib = os.path.join(dist_dir(), 'win-x64', 'node.lib')
       iojs_lib = os.path.join(dist_dir(), 'win-x64', 'iojs.lib')
     safe_mkdir(os.path.dirname(node_lib))
+    safe_mkdir(os.path.dirname(node2_lib))
     safe_mkdir(os.path.dirname(iojs_lib))
 
     # Copy atom.lib to node.lib and iojs.lib.
     atom_lib = os.path.join(output_dir(), 'node_import.lib')
     shutil.copy2(atom_lib, node_lib)
+    shutil.copy2(atom_lib, node2_lib)
     shutil.copy2(atom_lib, iojs_lib)
 
     # Upload the node.lib.
     s3put(bucket, access_key, secret_key, dist_dir(),
           'atom-shell/dist/{0}'.format(version), [node_lib])
+    s3put(bucket, access_key, secret_key, dist_dir(),
+          'atom-shell/dist/{0}'.format(version), [node2_lib])
 
     # Upload the iojs.lib.
     s3put(bucket, access_key, secret_key, dist_dir(),