This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
enable web request for incognito contexts
auditors: @bbondy, @diracdeltas
- Loading branch information
Showing
1 changed file
with
35 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2138301
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdfjs loads in private tabs with this change, but there is a cors error loading the actual pdf file
2138301
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++. the CORS error is documented here: brave/browser-laptop#2715. This commit (or something else in the Electron update) seems to break the webview.reload workaround though
2138301
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but i did confirm that going to https://letsencrypt.org/repository/ in a private tab and clicking the first PDF link loads it just fine. thanks!
2138301
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaks webview.reload in what way? This shouldn't have any effect on that at all