release unique_ptr to avoid double delete

auditors @darkdh @hferreiro
brave · Aug 8, 2018 · 25f50e6 · 25f50e6 · darkdh · Aug 8, 2018
1 parent dddf8d5
commit 25f50e6
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/brave/browser/resource_coordinator/guest_tab_manager.cc b/brave/browser/resource_coordinator/guest_tab_manager.cc
@@ -55,10 +55,11 @@ std::unique_ptr<WebContents> GuestTabManager::CreateNullContents(
 }
 
 void GuestTabManager::DestroyOldContents(
-    std::unique_ptr<WebContents> old_contents) {
+    std::unique_ptr<WebContents> old_contents_deleter) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
-  auto tab_helper = extensions::TabHelper::FromWebContents(old_contents.get());
+  auto old_contents = old_contents_deleter.release();
+  auto tab_helper = extensions::TabHelper::FromWebContents(old_contents);
   DCHECK(tab_helper && tab_helper->guest());
   // Let the guest destroy itself after the detach message has been received
   tab_helper->guest()->SetCanRunInDetachedState(false);