This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent
SuicideOnChannelErrorFilter
to be added to tor_launcher uti…
…lity process fix brave/browser-laptop#14636 SuicideOnChannelErrorFilter calls exit in OnChannelError() this will cause other endpoints listener can't finish their cleanup when pipe error happens(browser process crashed or be killed) and SuicideOnChannelErrorFilter::OnChannelError happens to be called before others. This should be fine for most of the cases but not tor_launcher service. `TorLauncher` requires StrongBinding::OnConnectionError to delete itself so that `~TorLauncher` will get called and terminate tor process. This should only happens on MacOS, SuicideOnChannelErrorFilter is guarded by OS_POSIX and Linux has `prctl(PR_SET_PDEATHSIG, SIGKILL)` so tor process will receive SIGKILL when tor_launcher utility process terminates prematurely Auditors: @riastradh-brave, @bridiver, @bbondy
- Loading branch information