This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
View certificate support #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
view_certificate
branch
2 times, most recently
from
5b52e98 to
4baf267
Compare
4 tasks
bridiver
force-pushed
the
master
branch
2 times, most recently
from
d8b3e75 to
349c547
Compare
|
@bbondy Are we holding off on this one until we have a UI for displaying on Linux? |
|
No I think we should merge and build for 0.13.6 as long as we have proper handling to not use it on linux on the front end. Please make sure an issue is posted though. Also @darkdh this needs a rebase pls, thanks. |
|
I don't see a file for win
… On Mar 11, 2017, at 6:37 PM, Brian R. Bondy ***@***.***> wrote:
No I think we should merge and build for 0.13.6 as long as we have proper handling to not use it on linux on the front end. Please make sure an issue is posted though.
Also @darkdh this needs a rebase pls, thanks.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Defer view certificate support on linux fix brave/browser-laptop#2611 Auditors: @bridiver, @bbondy
darkdh
force-pushed
the
view_certificate
branch
from
4baf267 to
70fb1b7
Compare
|
@bridiver There is |
|
++ |
bridiver
reviewed
Mar 22, 2017
| @@ -162,6 +162,9 @@ Object.assign(BrowserWindow.prototype, { | |||
| inspectServiceWorker () { | |||
| return this.webContents.inspectServiceWorker() | |||
| }, | |||
| showCertificate () { | |||
There was a problem hiding this comment.
is this needed for anything? There will never be a certificate for the browser-window
There was a problem hiding this comment.
You are right. Removed in 4deb4b2
darkdh
added a commit
that referenced
this pull request
Mar 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only support on mac and windows
fix brave/browser-laptop#2611