This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Pull in fixes for frameless window from upsteam electron #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
suggested changes
May 5, 2017
There was a problem hiding this comment.
I love PRs that are mostly deleted code ++
Please remove https://github.com/brave/muon/pull/191/files#diff-1705e33e1604cdb5e50ba3f82cdbdb57R61 as discussed so we don't have conflicting ldflags and it's good to merge
- manually applied: electron/electron@638eae1 - manually applied: https://github.com/electron/electron/pull/9167/files Passes the correct subsystem variable to linker. Before, older Windows version was being used which affected GetSystemMetrics (wrong values returned) Should fix brave/browser-laptop#7641 Should fix brave/browser-laptop#7215 Might fix brave/browser-laptop#5159 Auditors: @bbondy, @bridiver
bsclifton
force-pushed
the
windows-hitbox-fixes
branch
from
8f864fb to
5012b72
Compare
|
done 😄 |
bsclifton
added a commit
that referenced
this pull request
May 17, 2017
Initial PR was done with #191 but I missed electron/electron@dcf6c52 Fixes brave/browser-laptop#8839 Auditors: @bbondy, @bridiver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the correct subsystem variable to linker. Before, older Windows version
was being used which affected GetSystemMetrics (wrong values returned)
Should fix brave/browser-laptop#7641
Should fix brave/browser-laptop#7215
Might fix brave/browser-laptop#5159
Auditors: @bbondy, @bridiver