Expose missing spell checking interface #301
Conversation
| content::BrowserThread::GetTaskRunnerForThread( | ||
| content::BrowserThread::UI); | ||
| #if BUILDFLAG(ENABLE_SPELLCHECK) | ||
| registry->AddInterface( |
There was a problem hiding this comment.
that's odd, I noticed this when reviewing and I thought I saw it in the final PR
There was a problem hiding this comment.
you are still missing
+#if BUILDFLAG(HAS_SPELLCHECK_PANEL)
+ registry->AddInterface(base::Bind(&SpellCheckPanelHostImpl::Create),
+ ui_task_runner);
+#endif
see 08fdafe21e81711142065b8251af2e5ecd268707
There was a problem hiding this comment.
what is HAS_SPELLCHECK_PANEL ? are you sure that's something we need?
There was a problem hiding this comment.
It is an MacOS feature and chromium uses it as a spell-correction aid for contentEditable,
and <textarea>, and designMode document content that has the
focus on the current web page.
We new a instance of SpellCheckPanel in our BraveContentRendererClient
| content::BrowserThread::GetTaskRunnerForThread( | ||
| content::BrowserThread::UI); | ||
| #if BUILDFLAG(ENABLE_SPELLCHECK) | ||
| registry->AddInterface( |
There was a problem hiding this comment.
you are still missing
+#if BUILDFLAG(HAS_SPELLCHECK_PANEL)
+ registry->AddInterface(base::Bind(&SpellCheckPanelHostImpl::Create),
+ ui_task_runner);
+#endif
see 08fdafe21e81711142065b8251af2e5ecd268707
Expose missing spell checking interface
Expose missing spell checking interface
| @@ -243,6 +243,10 @@ void BraveContentBrowserClient::ExposeInterfacesToRenderer( | |||
| base::Bind(&SpellCheckHostImpl::Create, render_process_host->GetID()), | |||
| ui_task_runner); | |||
| #endif | |||
| #if BUILDFLAG(HAS_SPELLCHECK_PANEL) | |||
There was a problem hiding this comment.
@bridiver I believe this should be enclosed in the previous define (ENABLE_SPELLCHECK).
This should fix brave/browser-laptop#10849. Tested on Linux and Windows.