Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Issue: 15232 AllowScript should use atom::ContentSettingsManager like other Allow* methods in the observer #651

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Issue: 15232 AllowScript should use atom::ContentSettingsManager like other Allow* methods in the observer #651

merged 1 commit into from
Oct 4, 2018

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Oct 2, 2018 •
edited
Loading

fix brave/browser-laptop#15232

Test Plan

  1. Open Brave and navigate to https://peltate-worth.000webhostapp.com/world.html
  2. Enable Block Scripts for the domain
  3. Click on Show Message - alert box should not be displayed.

@jumde jumde requested a review from bridiver October 2, 2018 03:43
@bsclifton bsclifton changed the base branch from master to C69 October 3, 2018 18:15
@darkdh darkdh merged commit b67288b into C69 Oct 4, 2018
@Saloha
Copy link

Saloha commented Oct 4, 2018

c18663a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bridiver bridiver bridiver approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jumde @Saloha @bridiver @darkdh