Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manifest V2 checks to full desktop manual pass template #601

Merged
merged 1 commit into from
Aug 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions WikiTemplate/Desktop/wikitemplate.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,24 @@

- [ ] Verify that installing https://chrome.google.com/webstore/detail/adblock-plus-free-ad-bloc/cfhdojbkjhnklbpkdaibdccddilifddb from CWS displays the `Brave has not reviewed the extension.` warning via the "Add Extension" modal

### Manifest V2 Extensions

- [ ] Under `brave://settings/extensions/v2` toggle "Enable NoScript" on. Be sure to turn off any other extensions listed here if they are on.
- [ ] Navigate to https://underpassapp.com/StopTheScript/noscript.html and confirm that the page says "JavaScript is disabled".
- [ ] Confirm you can open the extension's panel without any errors.
- [ ] Under `brave://settings/extensions/v2` toggle "Enable uBlock Origin" on. Be sure to turn off any other extensions listed here if they are on.
- [ ] Navigate to a site which contains ads and toggle shields off. Reload the page and confirm ads are still blocked.
- [ ] Confirm you can open the extension's panel without any errors.
- [ ] Confirm panel reflects that items are blocked as expected.
- [ ] Under `brave://settings/extensions/v2` toggle "Enable uMatrix" on. Be sure to turn off any other extensions listed here if they are on.
- [ ] Navigate to a site which contains ads and toggle shields off. Reload the page and confirm ads are still blocked.
- [ ] Confirm you can open the extension's panel without any errors.
- [ ] Confirm panel reflects that items are blocked as expected.
- [ ] Under `brave://settings/extensions/v2` toggle "Enable AdGuard" on. Be sure to turn off any other extensions listed here if they are on.
- [ ] Navigate to a site which contains ads and toggle shields off. Reload the page and confirm ads are still blocked.
- [ ] Confirm you can open the extension's panel without any errors.
- [ ] Confirm panel reflects that items are blocked as expected.

### PDF

- [ ] Test that you can print a PDF
Expand Down