Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-3499] Content cleanup + clarifying requirements #8916

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Feb 4, 2025

Why are you making this change? (required)

Feedback from a mobile dev using the SDK: I think many other people would be implementing content cards in this manner. It would be great if the SDK used a UICollectionView instead of a UITableView so that you can easily switch the layout. Or just improve the wording in the documentation to say in order to do this it would need to be a fully custom implementation.

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Tag @braze-inc/docs-team in a comment below.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@internetisaiah internetisaiah marked this pull request as ready for review February 4, 2025 01:24
@internetisaiah internetisaiah requested a review from a team February 4, 2025 01:24
@rachel-feinberg rachel-feinberg requested review from rachel-feinberg and removed request for a team February 4, 2025 18:23
Copy link
Contributor

@rachel-feinberg rachel-feinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Left a couple comments

@internetisaiah internetisaiah merged commit 348caac into develop Feb 4, 2025
1 of 7 checks passed
@internetisaiah internetisaiah deleted the BD-3499 branch February 4, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants