implement semantic highlighting (#49) #50
+100
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! Will take a look this week, thanks :) |
AraneusRota
force-pushed
the
issue-49_semantic-highlighting
branch
from
08e271f to
2864e0b
Compare
|
Hi @brcosta, any update on the merge? I just rebased my commit onto the newest version :) |
Works for all symbols and keywords. Namespaces are treated as separate highlighted elements. For symbols that was the behaviour by default and for keywords the ns range had to be manually added.
AraneusRota
force-pushed
the
issue-49_semantic-highlighting
branch
from
2864e0b to
8fef008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for all symbols and keywords. Namespaces are treated as separate highlighted elements. For symbols that was the behavior by default and for keywords the ns range had to be manually added.
The only small gripe I still have is that now everything is highlighted because there is no syntax to exclude like in other languages (especially if you also enable rainbow parentheses). Personally, at first I also had to get used to semantic highlighting for other languages but now don't want to miss it anymore. Maybe it's again just a matter of getting used to.
Fixes #49