Enable eslint-expect-type for all projects (#1616)

It's a really useful plugin: https://github.com/JoshuaKGoldberg/eslint-plugin-expect-type You use it like this: ```ts // $ExpectType string const foo = "123" ``` It will fail `lint` if the type doesn't exactly match what you say.
breadboard-ai · May 1, 2024 · c5ea046 · c5ea046
1 parent 3b2bb4a
commit c5ea046
Show file tree

Hide file tree

Showing 64 changed files with 225 additions and 26 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -3,7 +3,11 @@
     "browser": true,
     "es2021": true
   },
-  "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:expect-type/recommended"
+  ],
   "overrides": [],
   "ignorePatterns": ["dist"],
 
@@ -12,7 +16,7 @@
     "ecmaVersion": "latest",
     "sourceType": "module"
   },
-  "plugins": ["@typescript-eslint"],
+  "plugins": ["@typescript-eslint", "eslint-plugin-expect-type"],
   "rules": {
     "@typescript-eslint/no-unused-vars": [
       "warn",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -180,6 +180,7 @@
     "@typescript-eslint/parser": "^7.8.0",
     "ava": "^5.2.0",
     "eslint": "^8.57.0",
+    "eslint-plugin-expect-type": "^0.4.0",
     "npm-ci": "^0.0.2",
     "rimraf": "^5.0.5",
     "rollup": "^4.17.2",

diff --git a/packages/agent-kit/.eslintrc b/packages/agent-kit/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/agent-kit/package.json b/packages/agent-kit/package.json
@@ -104,6 +104,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/breadboard-cli/.eslintrc b/packages/breadboard-cli/.eslintrc
@@ -0,0 +1,16 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+  "overrides": [
+    {
+      "files": ["!./vite.config.ts"],
+      "parserOptions": {
+        "project": false,
+      },
+      "rules": {
+        "expect-type/expect": "off",
+      },
+    },
+  ],
+}
diff --git a/packages/breadboard-cli/package.json b/packages/breadboard-cli/package.json
@@ -94,6 +94,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/breadboard-extension/.eslintrc b/packages/breadboard-extension/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/breadboard-extension/package.json b/packages/breadboard-extension/package.json
@@ -146,6 +146,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/breadboard-python/.eslintrc b/packages/breadboard-python/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/breadboard-server/.eslintrc b/packages/breadboard-server/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/breadboard-server/package.json b/packages/breadboard-server/package.json
@@ -64,6 +64,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/breadboard-ui/.eslintrc b/packages/breadboard-ui/.eslintrc
@@ -0,0 +1,16 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+  "overrides": [
+    {
+      "files": ["!./vite.config.ts"],
+      "parserOptions": {
+        "project": false,
+      },
+      "rules": {
+        "expect-type/expect": "off",
+      },
+    },
+  ],
+}
diff --git a/packages/breadboard-ui/package.json b/packages/breadboard-ui/package.json
@@ -87,6 +87,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/breadboard-web/.eslintrc b/packages/breadboard-web/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/breadboard/.eslintrc b/packages/breadboard/.eslintrc
@@ -1,18 +1,5 @@
 {
-  "plugins": ["eslint-plugin-expect-type"],
-  "extends": ["plugin:expect-type/recommended"],
   "parserOptions": {
-    "project": ["./tsconfig.json"]
+    "project": ["./tsconfig.json"],
   },
-  "rules": {
-    "@typescript-eslint/ban-types": [
-      "warn",
-      {
-        "types": {
-          "Function": false
-        },
-        "extendDefaults": true
-      }
-    ]
-  }
 }
diff --git a/packages/breadboard/package.json b/packages/breadboard/package.json
@@ -159,7 +159,6 @@
     "@typescript-eslint/eslint-plugin": "^7.7.1",
     "@typescript-eslint/parser": "^7.8.0",
     "ava": "^5.2.0",
-    "eslint-plugin-expect-type": "^0.4.0",
     "jsonschema": "^1.4.1",
     "rollup": "^4.17.2",
     "typedoc": "^0.25.12",

diff --git a/packages/breadboard/src/kits/builder.ts b/packages/breadboard/src/kits/builder.ts
@@ -106,6 +106,7 @@ export class KitBuilder {
     } as KitConstructor<GenericKit<Handlers>>;
   }
 
+  // eslint-disable-next-line @typescript-eslint/ban-types
   static wrap<F extends Record<string, Function>>(
     params: KitBuilderOptions,
     functions: F
@@ -114,6 +115,7 @@ export class KitBuilder {
   > {
     const createHandler = (
       previous: NodeHandlers,
+      // eslint-disable-next-line @typescript-eslint/ban-types
       current: [string, Function]
     ) => {
       const [name, fn] = current;

diff --git a/packages/breadboard/src/new/grammar/node.ts b/packages/breadboard/src/new/grammar/node.ts
@@ -36,6 +36,7 @@ import { BuilderScope } from "./scope.js";
 import { Value, isValue } from "./value.js";
 import { isLambda } from "./board.js";
 
+// eslint-disable-next-line @typescript-eslint/ban-types
 const serializeFunction = (name: string, handlerFn: Function) => {
   let code = handlerFn.toString();
 

diff --git a/packages/breadbuddy/.eslintrc b/packages/breadbuddy/.eslintrc
@@ -0,0 +1,16 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+  "overrides": [
+    {
+      "files": ["!./vite.config.ts"],
+      "parserOptions": {
+        "project": false,
+      },
+      "rules": {
+        "expect-type/expect": "off",
+      },
+    },
+  ],
+}
diff --git a/packages/breadbuddy/package.json b/packages/breadbuddy/package.json
@@ -67,6 +67,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/build/.eslintrc b/packages/build/.eslintrc
@@ -1,13 +1,5 @@
 {
-  "plugins": ["eslint-plugin-expect-type"],
-  "extends": ["plugin:expect-type/recommended"],
   "parserOptions": {
     "project": ["./tsconfig.json"],
   },
-  "rules": {
-    "@typescript-eslint/no-unused-vars": [
-      "error",
-      { "argsIgnorePattern": "_.*" },
-    ],
-  },
 }
diff --git a/packages/cloud-function/.eslintrc b/packages/cloud-function/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/coffee-bot-board/.eslintrc b/packages/coffee-bot-board/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/coffee-bot-board/package.json b/packages/coffee-bot-board/package.json
@@ -83,6 +83,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/core-kit/.eslintrc b/packages/core-kit/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/core-kit/package.json b/packages/core-kit/package.json
@@ -66,6 +66,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/create-breadboard-kit/.eslintrc b/packages/create-breadboard-kit/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json", "./assets/tsconfig.json"],
+  },
+}
diff --git a/packages/create-breadboard-kit/package.json b/packages/create-breadboard-kit/package.json
@@ -56,6 +56,7 @@
       },
       "files": [
         "src/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/create-breadboard/.eslintrc b/packages/create-breadboard/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/create-breadboard/package.json b/packages/create-breadboard/package.json
@@ -43,6 +43,7 @@
       },
       "files": [
         "src/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/discovery-types/.eslintrc b/packages/discovery-types/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/discovery-types/package.json b/packages/discovery-types/package.json
@@ -60,6 +60,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/gemini-kit/.eslintrc b/packages/gemini-kit/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/gemini-kit/package.json b/packages/gemini-kit/package.json
@@ -77,6 +77,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/graph-integrity/.eslintrc b/packages/graph-integrity/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/graph-integrity/package.json b/packages/graph-integrity/package.json
@@ -63,6 +63,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/graph-playground/.eslintrc b/packages/graph-playground/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/graph-playground/package.json b/packages/graph-playground/package.json
@@ -96,6 +96,7 @@
         "src/**/*.ts",
         "wild/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/graph-runner/.eslintrc b/packages/graph-runner/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/graph-runner/package.json b/packages/graph-runner/package.json
@@ -60,6 +60,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/hello-world/.eslintrc b/packages/hello-world/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/import/.eslintrc b/packages/import/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}
diff --git a/packages/import/package.json b/packages/import/package.json
@@ -94,6 +94,7 @@
       "files": [
         "src/**/*.ts",
         "tests/**/*.ts",
+        ".eslintrc",
         "../../.eslintrc.json"
       ],
       "output": []

diff --git a/packages/json-kit/.eslintrc b/packages/json-kit/.eslintrc
@@ -0,0 +1,5 @@
+{
+  "parserOptions": {
+    "project": ["./tsconfig.json"],
+  },
+}