Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align default value of propertyName option #129

Conversation

nkabrown
Copy link
Contributor

@nkabrown nkabrown commented May 31, 2024

Discovered a mismatch in the default value assigned to propertyName in the expanded-types plugin which leads to a different CEM result when passing an options object to the plugin without a propertyName key such as expandTypesPlugin({ hideLogs: true }).

Screenshot 2024-05-31 at 12 13 40 AM

@break-stuff
Copy link
Owner

Thank you for the PR!

@break-stuff break-stuff merged commit 4fb3efe into break-stuff:main Jun 2, 2024
1 check passed
@nkabrown nkabrown deleted the align-expanded-types-default-prop-name branch June 3, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants