use intersection versus union for interface generation #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is included in 1.6.7 |
|
@break-stuff Was this version pushed to a registry? 👀 |
|
Oh, you're right. It didn't deploy properly. You should see it now. |
|
Still seeing it on 1.5.2: https://www.npmjs.com/package/custom-element-jsx-integration |
|
Sorry, I was thinking about the react wrappers project. 1.5.3 is now out. Thank you for keeping me honest. 😁 |
|
Works! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a union type is used, it prevents combining properties from the different interfaces, so you can't have a custom attribute along with
classNameon the same element despite the combination being valid. With an intersection type, you can combine partials of both without it throwing a compiler error.