Add comment on how to delete additional_hosts option #778
Conversation
brenner-tobias
added
the
documentation
WalkthroughThe pull request updates the documentation for the Cloudflared add-on, specifically focusing on clarifying the usage and implications of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
cloudflared/DOCS.md (2)
142-142: Improve grammar in the note.The note provides valuable information about DNS cleanup. However, use "cannot" instead of "can not" as it's more common in technical writing.
-**Note 1**: _If you delete a hostname from the list, it will not be served anymore. Nevertheless, you should also manually delete the DNS entry from Cloudflare since it can not be deleted by the add-on._ +**Note 1**: _If you delete a hostname from the list, it will not be served anymore. Nevertheless, you should also manually delete the DNS entry from Cloudflare since it cannot be deleted by the add-on._
146-151: Fix punctuation in the note.The note effectively demonstrates how to delete the
additional_hostsoption. However, there's a double punctuation that should be fixed.-**Note 2**: _If you want to fully delete the additional_hosts option, you have to add an empty array in the configuration as follows:._ +**Note 2**: _If you want to fully delete the additional_hosts option, you have to add an empty array in the configuration as follows:_🧰 Tools
🪛 LanguageTool
[formatting] ~147-~147: These punctuation marks differ from each other. Use only one if you are ending a sentence.
Context: ...ty array in the configuration as follows:._yaml additional_hosts: []###...(DOUBLE_PUNCTUATION_PREMIUM)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cloudflared/DOCS.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
cloudflared/DOCS.md
[style] ~144-~144: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ... the DNS entry from Cloudflare since it can not be deleted by the add-on._ Note 2:...
(CAN_NOT_PREMIUM)
[formatting] ~147-~147: These punctuation marks differ from each other. Use only one if you are ending a sentence.
Context: ...ty array in the configuration as follows:._ yaml additional_hosts: [] ###...
(DOUBLE_PUNCTUATION_PREMIUM)
Proposed Changes
Add comment on how to delete additional_hosts option in documentation
Related Issues
#776
Summary by CodeRabbit
additional_hostsconfiguration