Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Small Issue] Current-Command command specifications don't match text in ui #103

Closed
1 task
Savvasun opened this issue Jun 8, 2020 · 1 comment
Closed
1 task

Comments

@Savvasun
Copy link

Savvasun commented Jun 8, 2020

The command specifications in the Current Command textarea should match the descriptions that are written in "( )"s above the buttons in the UI:

What it says What the UI shows
--noconsole --windowed
--nowindowed --console
  • The file that needs to be fixed is configurations.js
    • A possible fix for this could be getting command data from the the index.html file

This issue is informative as well as a request. I may be able to fix this myself soon.

@brentvollebregt
Copy link
Owner

brentvollebregt commented Jun 9, 2020

Yep, this is incorrect, when you click the "Console Based" it should show --console and when clicking "Window Based" it should show --windowed.

Looking at options.map(x => x.option_strings) in the UI, it seems this option has three possible strings per state (console / window). A solution to this would be to always try to get the second string but use the first if there is no second; looks like this handles each option well still - verification: options.map(x => x.option_strings[x.option_strings.length === 1 ? 0 : 1]).

I've just put a commit into develop now, thanks heaps for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants