Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n.js #211

Closed
wants to merge 27 commits into from
Closed

Update i18n.js #211

wants to merge 27 commits into from

Conversation

ystartgo
Copy link

@ystartgo ystartgo commented Nov 7, 2021

Add traditional chinese language

Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just wondering if this is currently working with the missing comma.

},
other: {
en: 'Other',
zh: '其他'
zh: '其他',
zh_tw: '其它'
},
},
button: {
// For the usage of interface.js_createSubSectionInAdvanced
browseForFile: {
en: 'Browse for File',
zh: '浏览文件'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a comma here - does this work for you?

@brentvollebregt brentvollebregt changed the base branch from master to develop November 18, 2021 08:31
@brentvollebregt
Copy link
Owner

@ystartgo do you mind fixing the comma so I can merge your PR? Otherwise, I can copy this out into a new commit.

brentvollebregt added a commit that referenced this pull request Nov 24, 2021
Changes were originally from #211 however the creator of the PR has not responded so I have manually added the changes after fixing them myself.
@brentvollebregt
Copy link
Owner

I have manually put this in develop now (due to no changes being made)

@brentvollebregt
Copy link
Owner

This feature has been released in v2.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants