Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudinary Setup and images added to home page. #146

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Cloudinary Setup and images added to home page. #146

merged 2 commits into from
Feb 16, 2021

Conversation

jaamz
Copy link
Collaborator

@jaamz jaamz commented Feb 13, 2021 •
edited
Loading

Done

  • Cloudinary base added into repo
  • Helper function created to convert images to Cloudinary URL
  • Home page images have been properly sourced to Cloudinary URL

Questions

  • Discuss more default parameters for images
  • Use Tailwind CSS? Or transform images in helper function

@jaamz jaamz linked an issue Feb 13, 2021 that may be closed by this pull request
Image Cleanup #61
Closed
1 task
pattruong
pattruong requested changes Feb 14, 2021
View reviewed changes
Copy link
Member

@pattruong pattruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the fix in package json

package.json Outdated Show resolved Hide resolved
@pattruong pattruong self-requested a review February 16, 2021 21:04
@pattruong pattruong merged commit 5957953 into stage Feb 16, 2021
@pattruong pattruong deleted the cloudinary-integration branch February 16, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattruong pattruong pattruong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image Cleanup
2 participants
@jaamz @pattruong