Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attest trezor-firmare core/v2.6.0 with mac support #1

Merged

Conversation

fletcher86
Copy link
Contributor

@fletcher86 fletcher86 commented May 30, 2023

Verified build using macOS Ventura 13.3.1 (a) (22E772610a)

@fletcher86 fletcher86 changed the title mac support Attest trezor-firmare core/v2.6.0 with mac support May 30, 2023
@fletcher86 fletcher86 marked this pull request as ready for review May 30, 2023 22:18
@brianddk
Copy link
Owner

brianddk commented May 31, 2023

Awesome. I'll tag the current tree at v0.1 then merge and tag at v0.2

After the merge I'll cut a new branch "mac-support" to try some revisions. I'll test for shasum and grealpath to prevent the need for extra installs or symlinks. But at this point ChatGPT is my macOS consultant, so might need someone to check my work.

@fletcher86
Copy link
Contributor Author

Sure np

@brianddk brianddk merged commit fe35cb8 into brianddk:main May 31, 2023
@brianddk
Copy link
Owner

OK... see if the mac_support branch works. I've put a bunch of the version checks into settings.sh.

https://github.com/brianddk/attestation/tree/mac_support

Also, your attest file had mis-matched checksums so I failed it, but hopefully you can get a clean build with the updates.

@fletcher86
Copy link
Contributor Author

Ok, I'll see if I can get to it. (at the very latest this weekend). Been really busy today on my day job.

@brianddk
Copy link
Owner

Sure... thx... BTW... grab latest, Just pushed 519f0c4 with a few more changes.

@fletcher86
Copy link
Contributor Author

fletcher86 commented May 31, 2023

I see where the checksum mismatches based on this screenshoot. I'm getting the same value I got before. I wonder if its because I'm running an M1 chip for my macbook air? Mine on left, yours on right.
image

@fletcher86
Copy link
Contributor Author

fletcher86 commented Jun 1, 2023

qq:

Should the checksums be the same for each 'trezor-2.6.0.bin' and 'repo/build/core/firmware/firmware.bin' below? Because I keep getting the same value as before.

c33e336869964cfb1ef193195894e8b6667955b4ea3044558c380b1787168e38 trezor-2.6.0.bin
d8650a84f119ac1cde2bf7f07471aa8f75cabad90e8e8a99707e9d8fcdf40028 repo/build/core/firmware/firmware.bin

c0b7696ce45ac9fe593eb9af1eb561f66cdf8be4d6a6bea6e538e252843e8a2f trezor-2.6.0-bitcoinonly.bin
17619deda90e1bf9e3170b15b82c67acd2f1b5e3ebd969199372ed34e2dfbe9f repo/build/core-bitcoinonly/firmware/firmware.bin

@fletcher86 fletcher86 deleted the fletcher/attestation-with-mac-support branch June 1, 2023 11:13
@brianddk
Copy link
Owner

brianddk commented Jun 1, 2023

Yes, the two by two lines are supposed to match. I updated the check.sh script to make this more apparent. I encountered similar problems legacy/bl1.11.0, checksums wouldn't match, but repeated attempts yielded the same results. I even scrubbed the logs line for line looking for failures and could find none. Eventually, I wiped my docker cache and the entire repo directory then things improved.

Best I could imagine is that jumping from one docker image to another, the image rebuild process will skip some steps or something. forcing it to build from scratch seemed to consistently yield correct results. Also do a size comparison on the files. Obviously the checksums won't match if the sizes don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants