-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hbase098, hbase10, hbase14, hbase20] HBase client updates #1113
Conversation
Here's what the added size looks like:
So revving through removing those old versions would help. |
After this set of changes:
Before it:
Looks like the two new modules added ~45 seconds to the build on my laptop. |
@apeksharma would you mind reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the two bindings and both seem to work.
<parent> | ||
<groupId>com.yahoo.ycsb</groupId> | ||
<artifactId>binding-parent</artifactId> | ||
<version>0.14.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 0.2.0-SNAPSHOT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the HEAD of master is definitely currently at 0.14.0-SNAPSHOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
And I had problem applying the patch ... failed against .bat file. |
Is your local checkout up to date with the main repo? |
+1 on commit then |
Thanks for the review! |
…ates [hbase098, hbase10, hbase14, hbase20] HBase client updates
Updates for version changes in the Apache HBase project
The latter two follow the same pattern as the HBase 1.2 binding where we reuse the implementation from the hbase10 binding and just swap in the shaded client jars.