Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hbase098, hbase10, hbase14, hbase20] HBase client updates #1113

Merged
merged 3 commits into from
Mar 23, 2018

Conversation

busbey
Copy link
Collaborator

@busbey busbey commented Mar 22, 2018

Updates for version changes in the Apache HBase project

  • deprecate 0.98 and 1.0 clients so we can remove them later.
  • add an HBase 1.4 client jar specific binding, in anticipation of the HBase project making that their stable version
  • add an HBase 2.0 client jar specific binding based on the HBase 2.0.0-beta-2 release to ease folks evaluating that release

The latter two follow the same pattern as the HBase 1.2 binding where we reuse the implementation from the hbase10 binding and just swap in the shaded client jars.

@busbey
Copy link
Collaborator Author

busbey commented Mar 22, 2018

Here's what the added size looks like:


Busbey-MBA:YCSB busbey$ ls -lah hbase*/target/*.{jar,tar.gz}
-rw-r--r--  1 busbey  staff    11K Mar 22 12:06 hbase098/target/hbase098-binding-0.14.0-SNAPSHOT.jar
-rw-r--r--  1 busbey  staff    27M Mar 22 12:06 hbase098/target/ycsb-hbase098-binding-0.14.0-SNAPSHOT.tar.gz
-rw-r--r--  1 busbey  staff   8.8K Mar 22 12:07 hbase10/target/hbase10-binding-0.14.0-SNAPSHOT.jar
-rw-r--r--  1 busbey  staff    29M Mar 22 12:07 hbase10/target/ycsb-hbase10-binding-0.14.0-SNAPSHOT.tar.gz
-rw-r--r--  1 busbey  staff   3.1K Mar 22 12:07 hbase12/target/hbase12-binding-0.14.0-SNAPSHOT.jar
-rw-r--r--  1 busbey  staff    30M Mar 22 12:07 hbase12/target/ycsb-hbase12-binding-0.14.0-SNAPSHOT.tar.gz
-rw-r--r--  1 busbey  staff   3.1K Mar 22 12:07 hbase14/target/hbase14-binding-0.14.0-SNAPSHOT.jar
-rw-r--r--  1 busbey  staff    35M Mar 22 12:07 hbase14/target/ycsb-hbase14-binding-0.14.0-SNAPSHOT.tar.gz
-rw-r--r--  1 busbey  staff   3.1K Mar 22 12:07 hbase20/target/hbase20-binding-0.14.0-SNAPSHOT.jar
-rw-r--r--  1 busbey  staff    41M Mar 22 12:07 hbase20/target/ycsb-hbase20-binding-0.14.0-SNAPSHOT.tar.gz

So revving through removing those old versions would help.

@busbey
Copy link
Collaborator Author

busbey commented Mar 22, 2018

After this set of changes:

Busbey-MBA:YCSB busbey$ ls -lah distribution/target/*.tar.gz
-rw-r--r--  1 busbey  staff   507M Mar 22 12:11 distribution/target/ycsb-0.14.0-SNAPSHOT.tar.gz

Before it:

Busbey-MBA:YCSB busbey$ ls -lah distribution/target/*.tar.gz
-rw-r--r--  1 busbey  staff   434M Mar 22 12:36 distribution/target/ycsb-0.14.0-SNAPSHOT.tar.gz

Looks like the two new modules added ~45 seconds to the build on my laptop.

@busbey
Copy link
Collaborator Author

busbey commented Mar 22, 2018

@apeksharma would you mind reviewing?

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the two bindings and both seem to work.

<parent>
<groupId>com.yahoo.ycsb</groupId>
<artifactId>binding-parent</artifactId>
<version>0.14.0-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 0.2.0-SNAPSHOT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the HEAD of master is definitely currently at 0.14.0-SNAPSHOT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@saintstack
Copy link
Contributor

And I had problem applying the patch ... failed against .bat file.

@busbey
Copy link
Collaborator Author

busbey commented Mar 23, 2018

And I had problem applying the patch ... failed against .bat file.

Is your local checkout up to date with the main repo?

@saintstack
Copy link
Contributor

+1 on commit then

@busbey busbey merged commit 2a7a77f into brianfrankcooper:master Mar 23, 2018
@busbey busbey deleted the hbase-client-updates branch March 23, 2018 18:56
@busbey
Copy link
Collaborator Author

busbey commented Mar 23, 2018

Thanks for the review!

ChrisG55 pushed a commit to ChrisG55/YCSB that referenced this pull request May 4, 2018
…ates

[hbase098, hbase10, hbase14, hbase20] HBase client updates
@busbey busbey mentioned this pull request May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants