-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mongodb] Update the pom.xml to make checkstyle fail the build. Fixes #365 #366
Conversation
/** | ||
* MongoDB client binding for YCSB. | ||
/* | ||
* Copyright (c) 2014, Yahoo!, Inc. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any kind of CLA that assigns copyrights to Yahoo!, so let's leave out adding these for now. I've been trying to think of the best way to handle #313 and all I've got so far is that adding Yahoo copyright statements isn't the way to go. :)
If they're already present, please leave them. That's a whole different mess.
with the copyright statement thing above addressed, I'm +1. |
(for other reviewiers, the fill diff without whitespace changes helped speed things up.) |
Should there be a "checkstyle.xml" file included in the PR? <configLocation>checkstyle.xml</configLocation> |
@cmatser - Interesting. Checkstyle was checking based on a config somewhere... I'll be honest I and say I just copied the blob from the root pom and then flipped the enforcing flags on. There is the checkstyle.xml file in the root directory and I just assumed it was using that one. I will see if setting the path to Maybe a better approach to this is to make the root pom enforcing and then update all of the poms except the MongoDB pom to override the configuration to not be enforcing. Then as we knock out sub-projects we just remove checkstyle item from the poms. |
Updated code to satisfy the checkstyle validation. Fixes brianfrankcooper#365
FYI - I did a force push of the amended commit to remove the bad copyright header. I also changed the path to the checkstyle.xml to be relative and it had not effect. I left it that way in the commit as I think it is clearer that it is referencing the file one directory up. |
Nice work! |
[mongodb] Update the pom.xml to make checkstyle fail the build. Fixes #365
[mongodb] Update the pom.xml to make checkstyle fail the build. Fixes brianfrankcooper#365
[mongodb] Update the pom.xml to make checkstyle fail the build. Fixes brianfrankcooper#365
Update the pom.xml to make checkstyle fail the build.
Updated code to satisfy the checkstyle validation.
Fixes #365