Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .travis_* files to ci/*. #1171

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Mar 2, 2021

The "ci" is the commonly used keyword not depending on the specific CI services.

Because for example the environment variable CI=true used in both GitHub Actions and Travis.
https://docs.github.com/en/actions/reference/environment-variables
https://docs.travis-ci.com/user/environment-variables/

@sodabrew
Copy link
Collaborator

sodabrew commented Mar 2, 2021

Yes! Great cleanup. I suggest this instead: new directory ci/ with each setup file moved there. No more dotfiles :)

@junaruga
Copy link
Contributor Author

junaruga commented Mar 2, 2021

Good idea! Let me change it on your suggested way.

The "ci" is the commonly used keyword not depending on the specific
CI services.
@junaruga junaruga force-pushed the wip/dot_travis_files branch from 6987259 to 423b243 Compare March 2, 2021 13:58
@junaruga junaruga changed the title Rename .travis_* files to .ci_*. Rename .travis_* files to ci/*. Mar 2, 2021
@junaruga
Copy link
Contributor Author

junaruga commented Mar 2, 2021

Rebased. I changed the commit message too. The CIs look good.

@sodabrew sodabrew merged commit cab1d34 into brianmario:master Mar 2, 2021
@junaruga junaruga deleted the wip/dot_travis_files branch March 2, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants