WIP: GitHub Actions: Add DB server MySQL, DB client MariaDB case. #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaruga
commented
Apr 10, 2021
| else | ||
| sudo apt-get install -qq libmysqlclient-dev | ||
| fi | ||
|
|
There was a problem hiding this comment.
I moved the logic to install libmysqlclient-dev or libmariadb-dev-compat from mysql80.sh to here. Because the environment variable DB_CLIENT is not available in the sudo bash.
This was referenced Apr 10, 2021
|
@junaruga I'm just wondering, is this use-case even officially supported? Maybe it will be easier to put some kind of warning for this use-case instead. |
|
I would close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1182 , #1183 , I want to add the case: DB server mysql, DB client: mariadb.