Setup default CA path if not provided #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
commented
Aug 27, 2021
| "/etc/ssl/certs/ca-certificates.crt", | ||
| "/etc/pki/tls/certs/ca-bundle.crt", | ||
| "/etc/ssl/ca-bundle.pem", | ||
| "/etc/ssl/cert.pem", |
There was a problem hiding this comment.
This list matches all common used paths as mentioned also at https://docs.planetscale.com/reference/secure-connections#ca-root-configuration.
https://github.com/golang/go/blob/master/src/crypto/x509/root_linux.go#L7-L14 has a somewhat similar list, but a number of those are not needed since those platforms then provide a symlink already in this list.
dbussink
force-pushed
the
dbussink/handle-default-ca-paths
branch
from
33c29bf to
78a44da
Compare
This adds setup of a default CA path if there's no path provided by the user. This enables easier configuration of system level CA validation if the MySQL server has a certificate signed by a system root. On more and more cloud based MySQL platforms system signed CA certificates are used and this hides the issue of selecting the appropriate path from the user. The real longer term answer here is that this is a default that changes in libmysqlclient itself. The current situation here is mixed. When using MariaDB (including the changes in #1205), the default system roots are already loaded and used if no CA is provided. On MySQL itself on the other hand, a CA path is required today. I have also opened a PR to improve that, see mysql/mysql-server#358 & https://bugs.mysql.com/bug.php?id=104649.
dbussink
force-pushed
the
dbussink/handle-default-ca-paths
branch
from
9a28614 to
6ae1d9a
Compare
|
This is excellent, thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds setup of a default CA path if there's no path provided by the user. This enables easier configuration of system level CA validation if the MySQL server has a certificate signed by a system root.
On more and more cloud based MySQL platforms system signed CA certificates are used and this hides the issue of selecting the appropriate path from the user.
The real longer term answer here is that this is a default that changes in libmysqlclient itself. The current situation here is mixed. When using MariaDB (including the changes in #1205), the default system roots are already loaded and used if no CA is provided.
On MySQL itself on the other hand, a CA path is required today. I have also opened a PR to improve that, see
mysql/mysql-server#358 & https://bugs.mysql.com/bug.php?id=104649.