Update DATETIME casting tests for mysql 8.0 #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Mysql 5, the invalid datetime was returned. However with 8.0 the returned row is `NULL`, so we can no longer detect this case and raise.
casperisfine
force-pushed
the
mysql8-update-datetime-casting-error-tests
branch
from
95d9695 to
d79638e
Compare
|
Thanks! |
junaruga
reviewed
Dec 2, 2021
| @@ -410,8 +410,13 @@ | |||
| end | |||
|
|
|||
| it "should raise an error given an invalid DATETIME" do | |||
| expect { @client.query("SELECT CAST('1972-00-27 00:00:00' AS DATETIME) as bad_datetime").each }.to \ | |||
| raise_error(Mysql2::Error, "Invalid date in field 'bad_datetime': 1972-00-27 00:00:00") | |||
| if @client.info[:version] < "8.0" | |||
There was a problem hiding this comment.
I seems that this part and another part on this PR to compare the MySQL client version will not work when the MySQL 10.0 is released in the future. The following way could be the solution.
if (@client.info[:version].split('.').map(&:to_i) <=> [8, 0]) < 0
The version is about MySQL not about Gem's, but the following way could be also possible technically.
if Gem::Version.new(@client.info[:version]) < Gem::Version.new("8.0")
I have not tested it by myself.
There was a problem hiding this comment.
To best honest it's test code, so it's not like it's gonna break apps updating or anything and we can always update it when we add MySQL 10 to the CI in 4 or 5 years.
But yeah, feel free to PR the Gem::Version one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1208
With Mysql 5, the invalid datetime was returned.
However with 8.0 the returned row is
NULL, so we can no longer detect this case and raise.NB: I chose not to change the behavior on 5.x, but we could also chose to change it to match 8.0 behavior. However I don't see any way to bring back that behavior on 8.0 because it's impossible to distinguish between a
NULLdatetime and an invalid one.