Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Actions workflows #1253

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Update GitHub Actions workflows #1253

merged 4 commits into from
Apr 26, 2022

Conversation

mishina2228
Copy link
Contributor

This PR does some minor enhancements for GitHub Actions workflows.

  • Bump actions/checkout from v2 to v3
  • Enable bundler-cache in ruby/setup-ruby

Some workflows fail, but I believe it has nothing to do with this change.

@sodabrew
Copy link
Collaborator

sodabrew commented Apr 18, 2022 •
edited
Loading

Thanks! Kicking off the CI run. Right, the failures related to the MySQL key are not caused by this change. I started working on fixing that but all the documentation I found pointed to the key already in use as the correct key to use for validating the packages.

@sodabrew
Copy link
Collaborator

Could you rebase? I took the nudge and checked the docs again and found the new signing keys for MySQL 5.7 and 8.0 latest.

@mishina2228
Update GitHub Actions workflows
838334a 
- Bump actions/checkout from v2 to v3
- Enable bundler-cache in ruby/setup-ruby
@mishina2228
Copy link
Contributor Author

Rebased!

sodabrew
sodabrew requested changes Apr 19, 2022
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/rubocop.yml Outdated Show resolved Hide resolved
@mishina2228
Copy link
Contributor Author

I added comments and skip installing gems for development.
@simi Thank you for letting me know!

  • Before 
    Bundle complete! 15 Gemfile dependencies, 27 gems now installed.
Bundled gems are installed into `./vendor/bundle`
  • After 
    Bundle complete! 15 Gemfile dependencies, 23 gems now installed.
Gems in the group 'development' were not installed.
Bundled gems are installed into `./vendor/bundle`

@mishina2228 mishina2228 requested a review from sodabrew April 23, 2022 02:38
@sodabrew sodabrew merged commit ffdd8c6 into brianmario:master Apr 26, 2022
@mishina2228 mishina2228 deleted the update-gh-actions branch April 27, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simi simi simi left review comments

@sodabrew sodabrew Awaiting requested review from sodabrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishina2228 @sodabrew @simi