Support connect attributes and set the script name to program_name attribute if it is not specified.
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -352,7 +352,36 @@ static VALUE rb_mysql_get_ssl_cipher(VALUE self) | |||
| return rb_str; | |||
| } | |||
|
|
|||
| static VALUE rb_connect(VALUE self, VALUE user, VALUE pass, VALUE host, VALUE port, VALUE database, VALUE socket, VALUE flags) { | |||
| #if MYSQL_VERSION_ID >= 50606 | |||
There was a problem hiding this comment.
I would prefer a have-function test on mysql_options4 rather than a version check.
|
This looks awesome, thank you for the contribution! Review comments added. |
|
I changed the code as you commented. |
…attribute if it is not specified.
sodabrew
pushed a commit
to sodabrew/mysql2
that referenced
this pull request
Nov 25, 2017
…attribute if it is not specified. (brianmario#760)
sodabrew
pushed a commit
to sodabrew/mysql2
that referenced
this pull request
Nov 25, 2017
…attribute if it is not specified. (brianmario#760)
sodabrew
pushed a commit
to sodabrew/mysql2
that referenced
this pull request
Nov 25, 2017
…attribute if it is not specified. (brianmario#760)
sodabrew
pushed a commit
to sodabrew/mysql2
that referenced
this pull request
Nov 25, 2017
…attribute if it is not specified. (brianmario#760)
|
Merged as 8d557b0 |
This was referenced Mar 21, 2018
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is same feature with Perl DBD-MySQL
mysql_conn_attrsoption.http://search.cpan.org/~capttofu/DBD-mysql-4.033/lib/DBD/mysql.pm#mysql_conn_attrs